Coding style

Topics: Developer Forum
Feb 19, 2009 at 10:14 AM
Hi all,

First of all thanks for all the works done, this lib works well if we forgot the huge memory usage (i know you work on it).
i have just a advice about the the class definition,near  everywhere you put class properties private, some time it's useful but in many place i think a protected properties should be better, just for exemple, if someone want to extend the HTML Writer Class (for adding behavior  ) he can't acces to the PHPExcel object and manipulate it.


Here is some reason about that ?

Beleneglorion.


Coordinator
Feb 19, 2009 at 11:05 AM
It allows us to provide backwards compatibility in all getters and setters and to poke around with all internals. Making these protected would provide either less flexibility for us to refactor things, or more breaking changes for people using the protected vars.

If required, we can consider making some protected instead of private. Can you create a work item describing the variables you need protected instead of private?