Sorting the cell collections

Topics: Developer Forum
Nov 6, 2008 at 2:59 AM
Edited Nov 6, 2008 at 3:11 AM
Hey developers,

We're currently sorting a cell collection when PHPExcel_Worksheet::getCellCollection is called but I can't see why it's needed anywhere other than in PHPExcel_ReferenceHelper::insertNewBefore.

I've made a simple patch (located here) and from my tests, it reduces the execution time of the '06largescale' test by roughly 25 seconds (out of 2:30)! I'm just wondering if this would cause any side effects or if the sort function should also be called during any other functions.

Thanks everyone,
Brian McKenna